Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker definition for http webserver spinup #82

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

Sakethanne
Copy link
Contributor

fix(docker): added docker definition for http webserver spinup

@Sakethanne Sakethanne requested a review from a team as a code owner November 5, 2024 21:08
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. we need to explain in commit why we adding http server if we already have https server
  2. we need iso_files folder to be created, otherwise we will fail... you can add this folder with small readme file part of this PR

@glimchb glimchb merged commit 5e03495 into opiproject:main Nov 6, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants