Fixed Lint errors and Merged Telegraf code on Monitoring.yml file #55
Conversation
|
@Sakethanne You need to fix the DCO check, the Linters check, and the Commitlint so we can review the changes. |
Sakethanne
force-pushed
the
main
branch
2 times, most recently
from
fefb77f
to
56b118d
Compare
Signed-off-by: sakethanne <[email protected]>
Signed-off-by: sakethanne <[email protected]>
Signed-off-by: sakethanne <[email protected]>
…AML files Signed-off-by: sakethanne <[email protected]>
Signed-off-by: sakethanne <[email protected]>
|
@sandersms I have fixed the DCO check and the Commitlint errors. I am not able to fix the Docker-Linter and Shell-Linters errors, and thise files have not been modified. |
It looks like Docker-lint and Shellcheck-lint have been failing, though set as required. |
sandersms
dismissed
their stale review
Latest checkin is failing DCO and Commitlint checks
|
@Sakethanne The DCO check is failing again. I had to revert the approval to await the resolution. Separately I am investigating the CI checking for docker-lint and shellcheck. |
|
@Sakethanne You will also need to update your project to pick up the latest changes with resolve the docker-lint issue that Boris checked in here and in the CI processing. |
…omplete site.yml Signed-off-by: sakethanne <[email protected]>
Signed-off-by: sakethanne <[email protected]>
|
@sandersms , I have pulledin the latest changes and them added some commits, signed off on them and pushed them. Please let me know if there are any checks that are still failing, and I will fix the ASAP. |
…ystems to PXE boot Signed-off-by: sakethanne <[email protected]>
Signed-off-by: sakethanne <[email protected]>
Signed-off-by: Boris Glimcher <[email protected]> Signed-off-by: sakethanne <[email protected]>
Signed-off-by: mohamedasifs123 <[email protected]> Signed-off-by: sakethanne <[email protected]>
Signed-off-by: sakethanne <[email protected]>
Signed-off-by: sakethanne <[email protected]>
Signed-off-by: sakethanne <[email protected]>
ansible/monitoring.yml
Outdated
| [ | ||
| { | ||
| 'type': 'bind', | ||
| 'source': inventory_hostname == 'bf2' and '/root/telegraf.d/telegraf.conf.bf2' or '/root/telegraf.d/telegraf.conf.mev', |
There was a problem hiding this comment.
instead of this, maybe do /root/telegraf.d/telegraf.conf.inventory_hostname
No description provided.