feat(bmc): add bmc_reboot_should_wait argument #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sachin-apa and @jcastanos2 please review |
glimchb
force-pushed
the
reboot
branch
3 times, most recently
from
701b465
to
d868b1c
Compare
sachin-apa
reviewed
Feb 23, 2024
glimchb
added a commit
that referenced
this pull request
Feb 27, 2024
Wait instead of sleep, see #30 Signed-off-by: Boris Glimcher <[email protected]>
glimchb
force-pushed
the
reboot
branch
3 times, most recently
from
3f54ef7
to
6e6fdac
Compare
Signed-off-by: Boris Glimcher <[email protected]>
glimchb
added
Merge Candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
Blocked by ansible-collections/community.general#8051 and ansible-collections/community.general#8434
Signed-off-by: Boris Glimcher [email protected]