Skip to content

Conversation

@titilambert
Copy link
Contributor

Hello !
I'm trying to split my last huuuuuuuge pull request...
This is what @matthieucan does with the "view engine" feature !

I hope you prefer pull requests like this...

@titilambert
Copy link
Contributor Author

Oki, It fails only with Django 1.5 strange ...

@matthieucan
Copy link
Contributor

is it different from #391 ?

@titilambert
Copy link
Contributor Author

@matthieucan It just mergeable with the last master ... So ... I will rebase your Pull Request and close this one ... Thanks !

@matthieucan
Copy link
Contributor

@titilambert Yep, you better keep the commit history :)

@titilambert
Copy link
Contributor Author

@matthieucan so the best one is this one #434 ?
You are still awake ?

@palli palli self-assigned this Oct 16, 2014
@matthieucan
Copy link
Contributor

(I'm always awake :) )
For the views engine the best one is still #391 (after rebase), #434 is a merge between the 2 masters, which contains more than this feature.

@palli
Copy link
Contributor

palli commented Oct 19, 2014

Can this pull request be closed in favor of #391 ?

The effort is good, much appreciated if you can do the same for the other features you have (i.e. one pull request for debian package updates, one for bower, etc)

@titilambert
Copy link
Contributor Author

I will try to do this...
@matthieucan Could you help me ?

@matthieucan
Copy link
Contributor

Sure. The best way is probably to look at the pull requests on savoirfairelinux/adagios, as every new feature had its own pull request over there.
We can sync via xmpp or irc if needed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants