[#253] AccountView에서 구글 계정을 링크 할 시 Main Thread Checker가 뜨는 이슈를 해결한다

[opficdev]

• closed AccountView에서 구글 계정을 링크 할 시 Main Thread Checker가 뜨는 이슈를 해결한다 #253

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses a Main Thread Checker warning that occurred when linking a Google account, by ensuring that UI-related operations are executed on the main thread. Additionally, it includes minor refactoring within the AccountViewModel for parameter naming consistency and enhances the AccountView's user interface by adding support for displaying toast messages.

Highlights

• Google Authentication Service: Resolved a Main Thread Checker issue by applying @mainactor to the link function and streamlining the retrieval of the top view controller, ensuring UI operations are performed on the main thread.
• AccountViewModel: Refactored parameter names from isPresented to presented in setAlert and setToast actions for improved clarity.
• AccountView UI: Integrated a new .toast modifier to the AccountView to enable the display of toast messages, enhancing user feedback.

Changelog

• DevLog/Infra/Service/SocialLogin/GoogleAuthenticationService.swift
  • Applied the @mainactor attribute to the link function to guarantee main thread execution for UI operations.
  • Simplified the logic for obtaining the top view controller by removing an explicit MainActor.run block.
• DevLog/Presentation/ViewModel/AccountViewModel.swift
  • Renamed the isPresented parameter to presented in both setAlert and setToast actions for better readability.
• DevLog/UI/Setting/AccountView.swift
  • Implemented a .toast view modifier to AccountView, allowing it to display transient messages to the user.

Activity

• Closed issue AccountView에서 구글 계정을 링크 할 시 Main Thread Checker가 뜨는 이슈를 해결한다 #253, indicating this pull request resolves a previously reported problem.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

안녕하세요. PR 리뷰를 맡게 된 수석 iOS 개발자입니다. 이번 PR은 AccountView에서 구글 계정 연동 시 발생하던 Main Thread Checker 이슈를 해결하고 토스트 메시지 기능을 추가하는 내용이네요. GoogleAuthenticationService의 link 함수에 @MainActor를 추가하여 UI 관련 코드가 메인 스레드에서 실행되도록 보장한 변경 사항은 올바른 해결 방법이며, 코드를 더 간결하게 만들었습니다. 전반적으로 좋은 수정이지만, AccountViewModel에서 변수명 일관성과 관련된 작은 개선점을 발견하여 코멘트를 남겼으니 확인 부탁드립니다.