-
Notifications
You must be signed in to change notification settings - Fork 0
[#245] 소셜 로그인을 취소했을 때 오류 얼럿이 뜨는 현상을 해결한다 #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // | ||
| // InfraLayerError.swift | ||
| // DevLog | ||
| // | ||
| // Created by opfic on 3/11/26. | ||
| // | ||
|
|
||
| import AuthenticationServices | ||
| import Foundation | ||
| import GoogleSignIn | ||
|
|
||
| enum FirestoreError: Error, LocalizedError { | ||
| case dataNotFound(_ key: String) | ||
|
|
||
| var errorDescription: String? { | ||
| switch self { | ||
| case .dataNotFound(let key): | ||
| return "\(key)가 Firestore에서 존재하지 않음" | ||
| } | ||
| } | ||
| } | ||
|
|
||
| enum UIError: Error { | ||
| case notFoundTopViewController | ||
| } | ||
|
|
||
| enum EmailFetchError: Error, Equatable { | ||
| case emailNotFound | ||
| case emailMismatch | ||
| } | ||
|
|
||
| enum SocialLoginError: Error { | ||
| case invalidOAuthState | ||
| case failedToStartWebAuthenticationSession | ||
| } | ||
|
|
||
| extension Error { | ||
| var isSocialLoginCancelled: Bool { | ||
| switch self { | ||
| // Apple 로그인 취소 | ||
| case let authError as ASAuthorizationError: | ||
| return authError.code == .canceled | ||
| // Github 로그인 취소 | ||
| case let webAuthError as ASWebAuthenticationSessionError: | ||
| return webAuthError.code == .canceledLogin | ||
| default: | ||
| let nsError = self as NSError | ||
| // Google 로그인 취소 | ||
| return nsError.domain == kGIDSignInErrorDomain && nsError.code == GIDSignInError.canceled.rawValue | ||
| } | ||
| } | ||
| } | ||
File renamed without changes.
File renamed without changes.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isSocialLoginCancelled프로퍼티의 가독성을 높이기 위해switch문을 사용하는 것을 제안합니다. 여러if let을 사용하는 현재 구현도 올바르게 동작하지만,switch를 사용하면 다양한 오류 유형을 더 명확하게 구분하고 코드를 더 깔끔하게 만들 수 있습니다.이렇게 변경하면 각 소셜 로그인 서비스별 취소 오류를 명시적으로 처리하는 구조가 되어 향후 다른 소셜 로그인이 추가되더라도 확장하기 용이합니다.