Task/61607 allow more characters for time entry comment #18000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaustopher
deleted the
task/61607-allow-more-characters-for-time-entry-comment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/stream-time-and-costs/work_packages/61607
What are you trying to accomplish?
Allow comments up to 1000 characters for time entries. We do want to increase the limit from the 255 we have right now. But we also do not want to allow arbitrary lengths of text. So we limit to 1000 characters on the model. DB is uncapped
Screenshots
What approach did you choose and why?
DB column is text, limit comes from rails
Merge checklist