[58427] Indicate that there are work package relations which the user has no permission to see #17604
Conversation
The mediator is responsible for providing the relations and children from a work package for the relations tab. This moves the responsibility of relations and children visibility in one central place.
…rning visible, invisible relations and their type
cbliard
force-pushed
the
code-maintenance/introduce-relations-tab-mediator
branch
from
a10a0be to
b0ee80c
Compare
…lations-which-the-user-has-no-permission-to-see
…lations-which-the-user-has-no-permission-to-see
…lations-which-the-user-has-no-permission-to-see
…lations-which-the-user-has-no-permission-to-see
There was a problem hiding this comment.
Nice work 👏
I only have two tiny code change requests.
I have also some 2 other questions / remarks about things that are not specified:
- For milestone work packages, I think it should show only one date like on the full page view
- For predecessor / successor ghost relation, when the dates are not set, I think the date line should still be shown, similar to what happens for ghost children without dates.
I asked both questions to Parimal in the related work package (#58427).
app/components/work_package_relations_tab/relations_mediator.rb
Outdated
Show resolved
Hide resolved
app/components/work_package_relations_tab/relations_mediator.rb
Outdated
Show resolved
Hide resolved
…b to use visible_relations instead of @visible_relations Co-authored-by: Christophe Bliard <[email protected]>
…b to use visible_children instead of @ visible_children Co-authored-by: Christophe Bliard <[email protected]>
…lations-which-the-user-has-no-permission-to-see
…of start and finish dates are the same
There was a problem hiding this comment.
Thanks, I found some issues:
- In the bottom of the page, there is the number of relations being displayed. Not sure why it happens, but it's a bug. I simply load the page with the relations, and this gimmick appears.
- For the dates widget, when there are no dates, a dash should be displayed. Currently nothing is displayed
It happens because of the condition start_date == due_date to display a single date. The condition is also true when both are nil.
Relevant text from the spec in 58427:
if a date missing (start date and/or finish date) we will nevertheless show the relevant icon with a dash (-) to indicate what is missing.
So I'll mark "review failed" for Feature: Indicate that there are work package relations which the user has no permission to see (#58427) for these two reasons.
- The icon for manually/automatically scheduled is displayed correctly for predecessors / successors, but not for children where the calendar icon is always displayed. Both should behave the same. I think the code to handle is currently duplicated for successors/predecessors and children and could be extracted into a method or a component so that it always behaves the same.
So I'll mark "review failed" for Bug: Icon beside dates of a relation is wrong in relation row (#60958)
And I'll mark "review approved" for both Feature: Relations tab: Show a single date when start and finish dates are the same (#61044) and Bug: Show dates of Children of a work package in relations tab (#60957).
Thanks @cbliard , I'll fix them 👍 |
…r in date picker too
cbliard
deleted the
58427-indicate-that-there-are-work-package-relations-which-the-user-has-no-permission-to-see
branch
Ticket
https://community.openproject.org/wp/58427
https://community.openproject.org/wp/60957
https://community.openproject.org/wp/60958
https://community.openproject.org/wp/61044
What are you trying to accomplish?
We want to show ghost relations of a WP in relations tab, but they will look different from visible relations.
Screenshots
What approach did you choose and why?
Return both visible and ghost relations to index component and then call relation component with different values for visible and ghost relations.
Merge checklist