Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[53809] Update PageHeaders & SubHeaders in the (rails) global index pages #16769

Merged

Conversation

bsatarnejad
Copy link
Contributor

@bsatarnejad bsatarnejad commented Sep 20, 2024

Ticket

https://community.openproject.org/projects/openproject/work_packages/53809/activity

What are you trying to accomplish?

Update page header and sub header in global index pages.

What approach did you choose and why?

Use our new PageHeader component instead of outdated toolbar implementation.

@bsatarnejad bsatarnejad self-assigned this Sep 20, 2024
Copy link

The provided work package version does not match the core version:

Please make sure that:

  • The work package version OR your pull request target branch is correct

@bsatarnejad bsatarnejad requested a review from a team September 26, 2024 05:28
@dombesz dombesz requested review from dombesz and removed request for a team September 26, 2024 09:54
Copy link
Contributor

@dombesz dombesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dombesz dombesz merged commit 62be46a into dev Sep 26, 2024
14 checks passed
@dombesz dombesz deleted the 53809-update-pageheaders-subheaders-in-the-rails-global-index-pages branch September 26, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants