-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[53809] Update PageHeaders & SubHeaders in the (rails) global index pages #16769
Merged
dombesz
merged 18 commits into
dev
from
53809-update-pageheaders-subheaders-in-the-rails-global-index-pages
Sep 26, 2024
Merged
[53809] Update PageHeaders & SubHeaders in the (rails) global index pages #16769
dombesz
merged 18 commits into
dev
from
53809-update-pageheaders-subheaders-in-the-rails-global-index-pages
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… project selected
…a project selected
…is a project selected
The provided work package version does not match the core version:
Please make sure that:
|
dombesz
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
dombesz
deleted the
53809-update-pageheaders-subheaders-in-the-rails-global-index-pages
branch
September 26, 2024 14:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/openproject/work_packages/53809/activity
What are you trying to accomplish?
Update page header and sub header in global index pages.
What approach did you choose and why?
Use our new PageHeader component instead of outdated toolbar implementation.