Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/57577 broken ordering by multi value custom fields #16762

Merged
merged 16 commits into from
Sep 26, 2024
Merged

Bug/57577 broken ordering by multi value custom fields #16762

merged 16 commits into from
Sep 26, 2024

Commits on Sep 24, 2024

  1. [#57577] Broken ordering by multi value custom fields 

    https://community.openproject.org/work_packages/57577
    @toy
    toy committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c695101 View commit details
    Browse the repository at this point in the history

  2. use array to order by user custom field instead of 3 order statements 

    Switch to using mail instead of id as agreed, as array can't contain
different types and mail is an unique string. This should not be a
security concern, as minimal information is exposed
    @toy
    toy committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2047b3d View commit details
    Browse the repository at this point in the history

  3. use quoted_table_name instead of table_name

    @toy
    toy committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a190ef0 View commit details
    Browse the repository at this point in the history

  4. inline version column as it is always and only name

    @toy
    toy committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d25bec9 View commit details
    Browse the repository at this point in the history

  5. eq_array matcher to be able to see a diff

    @toy
    toy committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c8639a3 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. use eq_array matcher to see difference in order when ordering by cust… 

    …om field is unexpected
    @toy
    toy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5be7a1d View commit details
    Browse the repository at this point in the history

  2. fix ordering of multi value list custom fields

    @toy
    toy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    749020d View commit details
    Browse the repository at this point in the history

  3. fix variable name

    @toy
    toy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    8d916a2 View commit details
    Browse the repository at this point in the history

  4. test ordering of objects with same values in different order

    @toy
    toy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e0b1cb6 View commit details
    Browse the repository at this point in the history

  5. remove duplication in list custom field ordering

    @toy
    toy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1d0a380 View commit details
    Browse the repository at this point in the history

  6. rename method for ordering list

    @toy
    toy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    b6ab023 View commit details
    Browse the repository at this point in the history

  7. use inner join

    @toy
    toy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e58a168 View commit details
    Browse the repository at this point in the history

  8. exclude empty values for list

    @toy
    toy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    15db96d View commit details
    Browse the repository at this point in the history

  9. handle ordering of multi value user custom fields

    @toy
    toy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    40af26b View commit details
    Browse the repository at this point in the history

  10. handle ordering of multi value version custom fields

    @toy
    toy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6199be8 View commit details
    Browse the repository at this point in the history

  11. squish and reformat other sql chunks

    @toy
    toy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c768f8b View commit details
    Browse the repository at this point in the history