-
Notifications
You must be signed in to change notification settings - Fork 261
release bundle attribute in version property #1792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1792 +/- ##
==========================================
+ Coverage 55.37% 55.63% +0.26%
==========================================
Files 136 137 +1
Lines 16003 16148 +145
==========================================
+ Hits 8861 8984 +123
- Misses 5987 6002 +15
- Partials 1155 1162 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
64f5075
to
ecf7b3a
Compare
7dd8b56
to
30f9439
Compare
Please note that this repo's merge method is set to squash, so all of these commits will get squished to a single one even if I forget to do it manually. They're preserved here mostly because there has been a lot of ground covered over the lifetime of this feature w.r.t. different implementation strategies, and I didn't want to lose that. |
Signed-off-by: grokspawn <[email protected]>
Signed-off-by: grokspawn <[email protected]>
Signed-off-by: grokspawn <[email protected]>
Signed-off-by: grokspawn <[email protected]>
Signed-off-by: grokspawn <[email protected]>
Signed-off-by: grokspawn <[email protected]>
Signed-off-by: grokspawn <[email protected]> Helped-by: Claude-LLM
30f9439
to
31ef961
Compare
Description of the change:
Adds a new bundle-scoped "release" flag to the existing version property to allow for more sophisticated replacement strategies with improved transparency.
Adds a new substitutesFor catalog template to help folks trivially adopt the new approaches and avoid common error scenarios.
Motivation for the change:
As brief and RFC state, the imperative upgrade graph building process had a CSV attribute "substitutesFor" which allowed tooling to perform bundle-level replacement in resulting graphs. We had no equivalent FBC approach to the problem where there is a packaging-only change which we need to insert into an existing graph in a way that it didn't pretend to be the original bundle, but made it possible to prefer the new bundle over the old one, and even upgrade from the old to the new.
Reviewer Checklist
/docs