✨ Upgrade bingo tooling deps #1703
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1703 +/- ##
==========================================
- Coverage 55.17% 55.08% -0.09%
==========================================
Files 136 136
Lines 15918 15896 -22
==========================================
- Hits 8782 8757 -25
- Misses 5983 5985 +2
- Partials 1153 1154 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
camilamacedo86
force-pushed
the
bingo
branch
3 times, most recently
from
8ca6d09 to
9f65c83
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: acornett21 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
|
||
| GORELEASER="${GOBIN}/goreleaser-v1.26.2" | ||
|
|
||
| PROTOC_GEN_GO_GRPC="${GOBIN}/protoc-gen-go-grpc-v1.3.0" | ||
| PROTOC_GEN_GO_GRPC="${GOBIN}/protoc-gen-go-grpc-v1.5.1" |
There was a problem hiding this comment.
@joelanford @grokspawn the methods changed for the latest, but I think we need to move forward right.
Could you please give a look on this one?
| GINKGO := $(GOBIN)/ginkgo-v2.23.4 | ||
| $(GINKGO): $(BINGO_DIR)/ginkgo.mod | ||
| @# Install binary/ries using Go 1.14+ build command. This is using bwplotka/bingo-controlled, separate go module with pinned dependencies. | ||
| @echo "(re)installing $(GOBIN)/ginkgo-v2.22.2" | ||
| @cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=ginkgo.mod -o=$(GOBIN)/ginkgo-v2.22.2 "github.com/onsi/ginkgo/v2/ginkgo" | ||
| @echo "(re)installing $(GOBIN)/ginkgo-v2.23.4" | ||
| @cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=ginkgo.mod -o=$(GOBIN)/ginkgo-v2.23.4 "github.com/onsi/ginkgo/v2/ginkgo" |
There was a problem hiding this comment.
We should also bump ginkgo in our go.mod to match.
There was a problem hiding this comment.
It is updated in the go.mod already
github.com/onsi/ginkgo/v2 v2.23.4
|
|
||
| require github.com/onsi/ginkgo/v2 v2.22.2 // ginkgo | ||
| toolchain go1.24.3 |
There was a problem hiding this comment.
Can we remove the toolchain line? Or does the dependency force it to be pulled in? (same question for all the dep bump mod files).
There was a problem hiding this comment.
That fails with
to latest...
Error: get: golangci-lint.mod: getting github.com/golangci/golangci-lint/cmd/golangci-lint@latest: install: list: go: golangci-lint.tmp.mod requires go >= 1.24.3 (running go 1.24.2)
: exit 1
Usage:
bingo get [flags] [<package or binary>[@version1 or none,version2,version3...]]
I think we need to ensure we go to 1.24.3 because of the downstream, right?
In downstream we have 1.24.3
There was a problem hiding this comment.
The value of the toolchain in the bingo files is the value for the operator-registries go version, which is 1.24.3. If this was updated to 1.24.4, the toolchain referenced here would be 1.24.4.
No description provided.