Skip to content

improve: showcase issue where updating the spec with SSA removes the finalizer #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Jul 4, 2025

No description provided.

csviri added 2 commits July 4, 2025 14:34
…nalizer

if the finalizer is not explicitly added to the fresh resource

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@openshift-ci openshift-ci bot requested review from metacosm and xstefank July 4, 2025 12:36
@csviri csviri changed the title ssa spec update improve: add sample when updating the spec with SSA it removes the finalizer Jul 4, 2025
@csviri csviri linked an issue Jul 4, 2025 that may be closed by this pull request
@csviri csviri changed the title improve: add sample when updating the spec with SSA it removes the finalizer improve: showcase isse when updating the spec with SSA it removes the finalizer Jul 4, 2025
@metacosm metacosm changed the title improve: showcase isse when updating the spec with SSA it removes the finalizer improve: showcase issue where updating the spec with SSA removes the finalizer Jul 9, 2025
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the purpose of this test should be? More precisely, I'm not sure we should add showcases to the test suite, such examples are probably better be put in the samples, rather as it's not testing anything in our implementation and just adds to the test running time.

@csviri
Copy link
Collaborator Author

csviri commented Jul 10, 2025

I'm not sure what the purpose of this test should be? More precisely, I'm not sure we should add showcases to the test suite, such examples are probably better be put in the samples, rather as it's not testing anything in our implementation and just adds to the test running time.

fair point, yes, it definitely adds to test running time, although these tests are relatively fast. We already have integration tests which are just showing some issue, or some corner cases. My goal was with these to add them to the test suit, so I can reference it from an upcomin blogpost, what will be also published from JOSDK repo.
I would not add it to the examples, IMO we should keep them clear, and mainly as easy to understand as possible for users who are starting to work with the framework.
Alternatively I could add it to a separate repo, which is also a bit problematic to separatelly maintain. Or just don't merge it and mention show code snippets in the blog, but I think it is always good if users can checkout and experiment with it.
Also it is good for us in the future for development purposes, like when reproducing issues to have such tests at hand.

Regarding the runtime of these integration tests is now something horrible, for a full e2e / IT test suit is ok to have a longer running time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding finalizer with SSA - Revisited
2 participants