Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: mapping from annotation depends on type #2586

Closed
wants to merge 96 commits into from
Closed

improve: mapping from annotation depends on type #2586

wants to merge 96 commits into from

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Nov 17, 2024

No description provided.

csviri and others added 30 commits November 13, 2024 20:02
@csviri
chore: set version to 5.0.0-SNAPSHOT (#2200)
611d174 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
improve: java version minimal 11, tested on 21 (#2207)
d2e0098 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
improve: remove deprecated EventFilter (#2208)
f8d3053 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
docs: 5.0 migration guide skeleton (#2210)
2a8dbe7 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
improve: managed dependent reconciliation results not optional (#2212)
20cd096 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
improve: remove deprecated RetryConfiguration (#2211)
9d680a4 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
feat: JDK client is now the default (#2235)
8da2c88 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm @csviri
fix: update SCM information (#2237)
0aad525 
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: move name is directly to dependent resource (#2250)
27e9376 
* feat: move name is directly to dependent resource

- use this name when throwing aggregate exception

Signed-off-by: Attila Mészáros <[email protected]>

* refactor to use a dedicated interface for setting the name

Signed-off-by: Attila Mészáros <[email protected]>

* refactor: add default implementation for name() (#2255)

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
format
ad74901 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
fix: test after rebase on master (#2270)
1aa3bf5 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
feat: use java 17 as baseline (#2271)
8744ab2 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
improve: matcher always considers metadata (#2273)
37c6867 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
feat: API to check if next reconciliation is imminent (#2272)
7927fc3 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
feat: Workflow extracted to a separate annotation (#2274)
7a24651 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
fix: pom properties cleanup (#2280)
8e799e2 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: remove EventSourceInitializer (#2257)
f3ade92 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm @csviri
refactor: make loadFromProperties private (#2287)
18cf3a5 
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
feat: distinguish resources based on desired state (#2252)
4fb5552 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
feat: explicit workflow invocation (#2289)
00a433f 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm @csviri
feat: use ssa for status update by default from UpdateControl (#2278)
9fba9fe 
Signed-off-by: Chris Laprun <[email protected]>
@metacosm @csviri
refactor: make WorkflowSpec an interface (#2300)
98c02ce 
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
improve: replace current formatting plugins with spotless plugin (#2302)
e58c7dd 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm @csviri
refactor: make ManagedWorkflowSupport public to be able to reuse it (#…
2899ae0 
…2308)

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
fix: package fix leader election sample (#2303)
4347e8f 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
feat: remove resource discriminator (#2299)
f236acc 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm @csviri
refactor: remove deprecated getTerminationTimeoutSeconds and associat…
2bd34de 
…ed (#2297)

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
improve: additional logging to mysql schema e2e test (#2320)
26e9d84 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm @csviri
feat: handle clustered resource on secondary to primary mapper init (#…
ab49b79 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
feat: using SSA for finalizer and primary patch (#2305)
bf7e58e 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri and others added 17 commits November 13, 2024 20:06
@csviri
feat: e2e test to demonstrate namespace deletion problem fix (#2528)
c18de80 

Signed-off-by: Attila Mészáros <[email protected]>
@csviri
docs: remove javadoc todos (#2541)
69e729d 
Signed-off-by: Attila Mészáros <[email protected]>
@10000-ki @csviri
feat: print diff resource as yaml (#2542)
b0522ff
@csviri
fix: integration test timeout issue (#2547)
a374796 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
improve: naming target resource selector method (#2546)
46ae8a2
@bachmanity1 @csviri
feat: improve diff logging (#2544)
a9b977f 
* imporve diff logging

Signed-off-by: bachmanity1 <[email protected]>

* compute diff only when actual doesn't match desired

Signed-off-by: bachmanity1 <[email protected]>

* slight improvements

Signed-off-by: bachmanity1 <[email protected]>

* increase context size

Signed-off-by: bachmanity1 <[email protected]>

* fix style

Signed-off-by: bachmanity1 <[email protected]>

* calculate diff only if debug is enabled

Signed-off-by: bachmanity1 <[email protected]>

* print actual resources when trace is enabled

Signed-off-by: bachmanity1 <[email protected]>

* use java-diff-utils

Signed-off-by: bachmanity1 <[email protected]>

* add unit tests

---------

Signed-off-by: bachmanity1 <[email protected]>
@metacosm @csviri
fix: race condition in workflow reconciler (#2549)
7a7cffd 
Signed-off-by: Chris Laprun <[email protected]>
@metacosm @csviri
feat(ci): split integration tests execution by category (#2548)
a0b10e6 
* feat(build): split ITs by category, parallel CRD generation

Also avoid generating CRDs when not needed by default, summarizes test
results.

* chore(deps): bump actions-setup-minikube to 2.13.0
* feat: default to use vertx client
* chore(ci): reduce tested combinations, only run client tests on baseapi
* fix: increase deletion timeout

---------

Signed-off-by: Chris Laprun <[email protected]>
@metacosm @csviri
refactor: rename method more appropriately (#2554)
f2ccea9 
Signed-off-by: Chris Laprun <[email protected]>
@csviri
improve: workflow builder naming (#2559)
85c7cb2
@metacosm @csviri
chore: adapt after rebase
7dce326 
Signed-off-by: Chris Laprun <[email protected]>
@Donnerbart @csviri
fix: infinite resource updates due to canonical format conversion of …
5f71aaa 
…resource requirements (#2565)

* refactor: clean up SSABasedGenericKubernetesResourceMatcher

Signed-off-by: David Sondermann <[email protected]>

* test: add missing tests for StatefulSet with VolumeClaimTemplates for SSABasedGenericKubernetesResourceMatcher

Signed-off-by: David Sondermann <[email protected]>

* fix: Fix infinite resource updates due to canonical format conversion of resource requirements

Signed-off-by: David Sondermann <[email protected]>

* test: Add test cases with init containers to ResourceRequirementsSanitizerTest

Signed-off-by: David Sondermann <[email protected]>

---------

Signed-off-by: David Sondermann <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
@csviri
fix: concurrent modification when getting event sources (v5) (#2572)
6157e2b
@csviri
fix: issue after rebase
45759ff 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
fix: formatting issue after rebase (#2582)
0d62265
@csviri
fix: docs double header in migration docs (#2584)
c62734a
@csviri
improve: mapping from annotation depends on type
aebf018 
Signed-off-by: Attila Mészáros <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2024
@csviri csviri linked an issue Nov 17, 2024 that may be closed by this pull request
Add "OwnerType" Annotation for Non-GC'ed DependentResources #2585
Open
@csviri csviri mentioned this pull request Nov 17, 2024
Open
@csviri
compiles
7785994 
Signed-off-by: Attila Mészáros <[email protected]>
csviri
csviri commented Nov 19, 2024
View reviewed changes
.../javaoperatorsdk/operator/baseapi/informerremotecluster/InformerRemoteClusterReconciler.java
@@ -53,7 +53,8 @@ public List<EventSource<?, InformerRemoteClusterCustomResource>> prepareEventSou
.from(ConfigMap.class, InformerRemoteClusterCustomResource.class)
// owner references do not work cross cluster, using
// annotations here to reference primary resource
.withSecondaryToPrimaryMapper(Mappers.fromDefaultAnnotations())
.withSecondaryToPrimaryMapper(
Mappers.fromDefaultAnnotations(InformerRemoteClusterCustomResource.class))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could eliminate the part where we pass the class of primary resource. Maybe a setter on SecondaryToPrimaryMapper for the primary class?
@metacosm

@csviri csviri requested a review from metacosm November 19, 2024 17:01
@csviri csviri marked this pull request as ready for review November 19, 2024 17:01
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2024
@openshift-ci openshift-ci bot requested a review from adam-sandor November 19, 2024 17:01
@csviri
Copy link
Collaborator Author

csviri commented Nov 20, 2024

replaced by: #2599

@csviri csviri closed this Nov 20, 2024
@csviri csviri removed a link to an issue Nov 22, 2024
Add "OwnerType" Annotation for Non-GC'ed DependentResources #2585
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm Awaiting requested review from metacosm

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@csviri @metacosm @10000-ki @matteriben @bachmanity1 @Donnerbart