-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 #208
deprecate-api validator: add checks for removed APIs on 1.25 and 1.26 #208
Conversation
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you please add an example of how to call this validation in the README?
HI @gallettilance, The README and the validator doc for the golang docs were supplemented. Thank you for your review. 🥇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm one nit: if they use these optional validators it would be good to produce a warning saying "deprecated apis were not detected. this validator cannot check operator code for the use of deprecated apis. please check your operator code to ensure that deprecated apis aren't in use." (something like that)
Hi @gallettilance:
The validators just raise warnings or errors (no info level logs #158). If we always introduce a warn by default, how can we easily identify when the checks passed successfully (nothing to report, not found) when not? For example, I want my report shows the result in yellow when any warning is raised and in red when we found an issue. I think that would be nice to be provided if we be able to do #158 and began to have an info level then, we could add this info by default. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
deprecate-api validator: add checks for removed APIs on 1.25 and 1.26
Motivation
If we found the removed APIs for 1.25 and 1.26 raise the warnings and errors accordingly.
Co-authored-by: Brett Tofel [email protected]
Closes: #151
Closes: #157