feat: move action buttons; implement the delete button#32
Merged
nikitalokhmachev-ai merged 5 commits intomainfrom May 22, 2025
Merged
feat: move action buttons; implement the delete button#32nikitalokhmachev-ai merged 5 commits intomainfrom
nikitalokhmachev-ai merged 5 commits intomainfrom
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Collaborator
Author
|
Found a bug related to ports disconnecting |
yamijuan
approved these changes
May 22, 2025
Shrinks99
approved these changes
May 22, 2025
Collaborator
Shrinks99
left a comment
There was a problem hiding this comment.
Looks good! Lets merge it :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
This PR tackles #30.
Here are the items implemented:
PR Type
Enhancement
Description
Moved action buttons to top bar
Added progressive disclosure of actions
Implemented delete functionality
Added selection count and clear selection
Changes walkthrough 📝
argo-archive-list.ts
Selection management and event dispatchingsrc/argo-archive-list.ts
clearSelection()method to reset selected pagesbg.ts
Backend deletion functionalitysrc/ext/bg.ts
deletePagesmessage handlersidepanel.ts
UI implementation of progressive disclosuresrc/sidepanel.ts
selectedCountproperty to track selectionsonDeleteSelected()method