-
Notifications
You must be signed in to change notification settings - Fork 0
Status Card + updates on tab change #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
| let err = null; | ||
|
|
||
| // @ts-expect-error - TS7034 - Variable 'err' implicitly has type 'any' in some locations where its type cannot be determined. | ||
| if (sidepanelPort) { | ||
| sidepanelPort.postMessage({ type: "update" }); | ||
| } | ||
| const { waitForTabUpdate } = opts; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The error comment about err variable is misplaced. It should be on the line where err is declared, not on the if (sidepanelPort) check. [general, importance: 7]
| let err = null; | |
| // @ts-expect-error - TS7034 - Variable 'err' implicitly has type 'any' in some locations where its type cannot be determined. | |
| if (sidepanelPort) { | |
| sidepanelPort.postMessage({ type: "update" }); | |
| } | |
| const { waitForTabUpdate } = opts; | |
| // @ts-expect-error - TS7034 - Variable 'err' implicitly has type 'any' in some locations where its type cannot be determined. | |
| let err = null; | |
| if (sidepanelPort) { | |
| sidepanelPort.postMessage({ type: "update" }); | |
| } | |
| const { waitForTabUpdate } = opts; |
PR Type
Enhancement
Description
Status card shows current page info
Updates status on tab change
Improved UI layout and styling
Fixed port handling for sidepanel
Changes walkthrough 📝
argo-archive-list.ts
CSS style reorganizationsrc/argo-archive-list.ts
.card-containerCSS rule to improve style organizationbg.ts
Background script updates for sidepanel communicationsrc/ext/bg.ts
sidepanelPortvariable to maintain connectionpopupHandlerfunctionchanges
recorder.ts
Enhanced status object with page metadatasrc/recorder.ts
favIconUrl,pageTitle, andtabIdto status objectsidepanel.ts
Status card implementation and UI enhancementssrc/sidepanel.ts
utils.ts
Utility functions for UI displaysrc/utils.ts
mapIntegerToRangefunction to convert integers to progressvalues
truncateStringfunction to limit string length for displaysidepanel.html
Simplified HTML structure with component-based approachstatic/sidepanel.html