Skip to content

Remove unused ArchiveWeb.page buttons & styling#15

Merged
Shrinks99 merged 5 commits intomainfrom
henry-awp-tweaks
May 9, 2025
Merged

Remove unused ArchiveWeb.page buttons & styling#15
Shrinks99 merged 5 commits intomainfrom
henry-awp-tweaks

Conversation

@Shrinks99
Copy link
Collaborator

@Shrinks99 Shrinks99 commented May 8, 2025

User description

Closes #3, #11

We may wish to merge this in a bit later after we've extracted all the controls that we're using just to make it easier on ourselves?

Changes

  • Comments out various ArchiveWeb.page related branding to revert it to its default "ReplayWeb.page" states
  • Removes new archiving session creation controls
  • Reverts prettier line wrapping to default (same as repo)
  • Changes default archiving session name to "My Archive"

PR Type

Enhancement


Description

  • Remove ArchiveWeb.page branding and controls

  • Rename default archive to "My Archive"

  • Comment out archiving session buttons

  • Revert prettier configuration to match repo


Changes walkthrough 📝

Relevant files
Enhancement
app.ts
Remove ArchiveWeb.page branding and controls                         

src/ui/app.ts

  • Commented out ArchiveWeb.page app name override
  • Removed User Guide link and ArchiveWeb.page logo
  • Commented out "Start Archiving" buttons
  • Commented out entire About modal with ArchiveWeb.page branding
  • +95/-98 
    coll-info.ts
    Remove archiving button from collection info                         

    src/ui/coll-info.ts

    • Commented out "Start Archiving" button from collection info view
    +2/-2     
    coll.ts
    Remove archiving button from toolbar                                         

    src/ui/coll.ts

  • Commented out renderToolbarLeft method that adds "Start Archiving"
    button
  • +24/-24 
    utils.ts
    Rename default archive collection                                               

    src/utils.ts

  • Changed default archive collection name from "My Archiving Session" to
    "My Archive"
  • +1/-1     
    Configuration changes
    .prettierrc
    Revert prettier configuration                                                       

    .prettierrc

  • Removed printWidth configuration to match original repository settings
  • +1/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @Shrinks99 Shrinks99 linked an issue May 8, 2025 that may be closed by this pull request
    3 tasks
    @nikitalokhmachev-ai
    Copy link
    Collaborator

    LGTM!

    @Shrinks99 Shrinks99 marked this pull request as ready for review May 9, 2025 18:45
    @pr-agent-monadical
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ✅

    3 - Fully compliant

    Compliant requirements:

    • Rename the default archive name from "My Archiving Session" to something more appropriate

    11 - Fully compliant

    Compliant requirements:

    • Remove Recording button in archive browser nav bar
    • Remove About ArchiveWeb.page button in menu
    • Remove ArchiveWeb.page logo on viewer
    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Code Commenting

    Large sections of code are commented out rather than removed. This approach might lead to maintenance issues in the future as commented code can become outdated or confusing.

    // renderAbout() {
    //   return html`
    //     <div class="modal is-active">
    //       <div class="modal-background" @click="${this.onAboutClose}"></div>
    //         <div class="modal-card">
    //           <header class="modal-card-head">
    //             <p class="modal-card-title">About ArchiveWeb.page ${this.getDeployType()}</p>
    //             <button class="delete" aria-label="close" @click="${
    //               this.onAboutClose
    //             }"></button>
    //           </header>
    //           <section class="modal-card-body">
    //             <div class="container">
    //               <div class="content">
    //                 <div class="is-flex">
    //                   <div class="has-text-centered" style="width: 220px">
    //                     <fa-icon class="logo" size="48px" .svg="${awpLogo}"></fa-icon>
    //                     <div style="font-size: smaller; margin-bottom: 1em">${this.getDeployType()} v${VERSION}</div>
    //                   </div>
    
    //                   ${
    //                     IS_APP
    //                       ? html`
    //                           <p>
    //                             ArchiveWeb.page App is a standalone app for Mac,
    //                             Windows and Linux that allows users to archive
    //                             webpages as they browse
    //                           </p>
    //                         `
    //                       : html` <p>
    //                           ArchiveWeb.page allows users to archive webpages
    //                           directly in your browser!
    //                         </p>`
    //                   }
    //                 </div>
    
    //                 <p>See the <a href="https://archiveweb.page/guide" target="_blank">ArchiveWeb.page Guide</a> for more info on how to use this tool.</p>
    
    //                 <p>Full source code is available at:
    //                   <a href="https://github.com/webrecorder/archiveweb.page" target="_blank">https://github.com/webrecorder/archiveweb.page</a>
    //                 </p>
    
    //                 <p>ArchiveWeb.page is part of the <a href="https://webrecorder.net/" target="_blank">Webrecorder Project</a>.</p>
    
    //                 <h3>Privacy Policy</h3>
    //                 <p class="is-size-7">ArchiveWeb.page allows users to archive what they browse, storing captured data directly in the browser.
    //                 Users can downloaded this data as files to their hard drive. Users can also delete any and all archived data at any time.
    //                 ArchiveWeb.page does not collect any usage or tracking data.</p>
    
    //                 <p class="is-size-7">ArchiveWeb.page includes an experimental sharing option for each archive collection. Users can choose to share select archives on a peer-to-peer network (IPFS) via a unique id.
    //                 Once shared on this network, the data may become accessible to others.
    //                 All archived items are private and not shared by default, unless explicitly opted-in by the user. (A warning is displayed when sharing via IPFS.)</p>
    
    //                 <h4>Disclaimer of Warranties</h4>
    //                 <p class="is-size-7">The application is provided "as is" without any guarantees.</p>
    //                 <details class="is-size-7">
    //                   <summary>Legalese:</summary>
    //                   <p style="font-size: 0.8rem">DISCLAIMER OF SOFTWARE WARRANTY. WEBRECORDER SOFTWARE PROVIDES THIS SOFTWARE TO YOU "AS AVAILABLE"
    //                   AND WITHOUT WARRANTY OF ANY KIND, EXPRESS, IMPLIED OR OTHERWISE,
    //                   INCLUDING WITHOUT LIMITATION ANY WARRANTY OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE.</p>
    //                 </details>
    
    //                 <div class="has-text-centered">
    //                   <a class="button is-warning" href="#" @click="${
    //                     this.onAboutClose
    //                   }">Close</a>
    //                 </div>
    //               </div>
    //             </div>
    //           </section>
    //         </div>
    //       </div>
    //     </div>`;
    // }
    Missing Variable

    The metadata variable is referenced before it's defined. The old code had the definition, but the new code only has the assignment of the title property.

    const metadata = { title: "My Archive" };
    const result = await collLoader.initNewColl(metadata);

    @pr-agent-monadical
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @Shrinks99 Shrinks99 merged commit d9e1485 into main May 9, 2025
    1 of 4 checks passed
    @Shrinks99 Shrinks99 deleted the henry-awp-tweaks branch May 9, 2025 18:55
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    Remove ArchiveWeb.page Branding & Controls from archive viewer Rename default archive name

    2 participants