Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite cluster onboarding issue template #168

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Conversation

larsks
Copy link
Contributor

@larsks larsks commented Mar 26, 2021

I thought the existing issue template was a little opaque for new
users, particularly for those without a lot of prior OpenShift
experience. I've tried to clarify it a bit.

This also surrounds most of the explanatory verbage in comments so
that it's hidden in the rendered issue.

You can see an example of what an issue looks once it's created here.

@sesheta sesheta requested review from 4n4nd and tumido March 26, 2021 18:24
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 26, 2021
I thought the existing issue template was a little opaque for new
users, particularly for those without a lot of prior OpenShift
experience. I've tried to clarify it a bit.

This also surrounds most of the explanatory verbage in comments so
that it's hidden in the rendered issue.
Copy link

@4n4nd 4n4nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsks @HumairAK should we also add a field asking for a brief description for the project?

@larsks
Copy link
Contributor Author

larsks commented Mar 26, 2021

@4n4nd I think that's a good idea, although I'd prefer to approve these changes first and then make a second PR where we can discuss the verbage for a new field.

Copy link

@4n4nd 4n4nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2021
@HumairAK
Copy link
Member

/lgtm

@HumairAK
Copy link
Member

HumairAK commented Mar 26, 2021

/lgtm
edit: woops double comment :(

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Nice simplification. I like it! 👍

@sesheta
Copy link
Member

sesheta commented Mar 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2021
@sesheta sesheta merged commit 9b954f3 into operate-first:main Mar 29, 2021
larsks added a commit to larsks/opf-support that referenced this pull request Mar 30, 2021
larsks added a commit to larsks/opf-support that referenced this pull request Mar 30, 2021
sesheta pushed a commit that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants