Two minor build fixes #445
Conversation
|
@OlCe2 Thank you for your PR and sorry for the late merge |
|
@OlCe2 It seems we have still a small problem: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
=======================================
Coverage 27.70% 27.70%
=======================================
Files 26 26
Lines 2534 2534
Branches 1363 1363
=======================================
Hits 702 702
Misses 1325 1325
Partials 507 507 ☔ View full report in Codecov by Sentry. |
Oh, my... Meson in the CI is at version 0.49.2, released in February 2019... It seems that multiline statements were not supported up to version 50.0. Are you planning to upgrade it soon? I can certainly change the commits to avoid line wrapping in the meantime. |
The dependency on libzim must be specified in compiler.has_header_symbol() for it to find the header in all cases (i.e., also when not installed in locations the compiler considers standard). This is essentially the same fix as was done earlier in libzim.
On FreeBSD, LLVM's libc++ also relies on pthread. zimcheck's 'meson.build' would use the same 'thread_dep' variable set in the root 'meson.build' file on building zimwriterfs, crushing the value set there in some cases, which would then be used in zimwriterfs' 'meson.build'. Note: Some of the introduced line is very long but has not been wrapped as Meson 0.49.2 is still used in the MacOS CI and it does not not support continuing lines with '\'.
No description provided.