-
-
Notifications
You must be signed in to change notification settings - Fork 19
Add utility to deduplicate ZIM items and replace them with redirects at ZIM creation time #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rgaudin can you give me a first feedback on the proposed API. Code is still missing any test and versions of new libraries in pyproject.toml are wrong, but I prefer to first get feedback on the API since I'm really not convinced this is the optimal approach, but I fail to find something more convenient |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 41 +1
Lines 2480 2512 +32
Branches 334 339 +5
=========================================
+ Hits 2480 2512 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
And btw, should we prefer alias to redirect? It is still unclear to me when we should prefer one to the other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ; thank you.
I appreciate that it's completely optional, explicit, independent and discrete.
We need to use it in the wild to see how it performs now.
37b6539
to
11f4df5
Compare
Fix #33
Note that this is kinda a resurrection of #86 where important things have already been discussed (e.g. the fact that we do not want to extend the Creator API but add a new distinct API to better trace memory issues)