Skip to content

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Jul 17, 2025

Fix #122
Fix #123

Nota: approach to remove inline JS is definitely applicable to all scrapers using a Vue.JS (i.e. as a solution to openzim/overview#52). I'm waiting for some feedback but at some point we should probably move this code to a NPM package for easier reusability / maintenance.

@benoit74 benoit74 self-assigned this Jul 17, 2025
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.13%. Comparing base (bf104ce) to head (2530d2b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   43.13%   43.13%           
=======================================
  Files           9        9           
  Lines         357      357           
  Branches       49       49           
=======================================
  Hits          154      154           
  Misses        199      199           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74
Copy link
Collaborator Author

Screen.Recording.2025-07-17.at.16.52.59.mov

@benoit74 benoit74 requested a review from kelson42 July 17, 2025 14:59
@kelson42 kelson42 merged commit c13a198 into main Jul 18, 2025
10 checks passed
@kelson42 kelson42 deleted the kiwix-desktop branch July 18, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove inline JS Replace Fetch API by Axios
2 participants