Skip to content

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Mar 7, 2025

Fix #79

Nota: I consider that this code should ultimately make its way to the python-scraperlib since it is a very generic way to handle ZIM illustration which probably matches most scraper needs. Could even be hidden behind the DefaultIllustrationMetadata which could accept a string as well as input and if such consider that it is the path or URL to illustration to use.

@benoit74 benoit74 self-assigned this Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 43.13%. Comparing base (e1b706e) to head (91f696a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/fcc2zim/scraper.py 55.55% 5 Missing and 3 partials ⚠️
scraper/src/fcc2zim/entrypoint.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   42.77%   43.13%   +0.36%     
==========================================
  Files           9        9              
  Lines         339      357      +18     
  Branches       45       49       +4     
==========================================
+ Hits          145      154       +9     
- Misses        193      199       +6     
- Partials        1        4       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 marked this pull request as ready for review March 7, 2025 08:43
@benoit74 benoit74 requested a review from rgaudin March 7, 2025 08:44
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; and I agree it should eventually move to scraperlib

@benoit74 benoit74 merged commit 5dc1085 into main Mar 9, 2025
10 checks passed
@benoit74 benoit74 deleted the custom_icon branch March 9, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom illustration
2 participants