zcp: get_prop: fix encryptionroot and encryption #17280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotin
reviewed
Apr 29, 2025
snajpa
force-pushed
the
zcp-props-fix
branch
3 times, most recently
from
de799a2 to
d8175b2
Compare
behlendorf
approved these changes
May 21, 2025
There was a problem hiding this comment.
It would be great to include @grahamc's test case if he doesn't mind. Please just keep it as a separate commit on top of yours so we can properly attribute it.
amotin
approved these changes
May 21, 2025
It was reported that channel programs' zfs.get_prop doesn't work for dataset properties encryption and encryptionroot. They are handled in get_special_prop due to the need to call dsl_dataset_crypt_stats to load those dsl props. Signed-off-by: Pavel Snajdr <[email protected]>
|
Let's please wait for the added test's result, just to be sure :) |
It appears that the current behavior is broken: * 'encryption' always being "off" * 'encryptionroot' always being null Signed-off-by: Graham Christensen <[email protected]> Merging notes from snajpa: - added SPDX tags - rebased (tests/zfs-tests/tests/Makefile.am) Signed-off-by: Pavel Snajdr <[email protected]>
|
Ah, the checkstyle - license tags - added and pushed |
behlendorf
added
Status: Accepted
amotin
reviewed
May 22, 2025
tests/zfs-tests/tests/functional/channel_program/lua_core/tst.encryption.ksh
Show resolved
Hide resolved
github-actions
bot
removed
the
Status: Accepted
Fixes the newly added tst.encryption.ksh and also tst.exists.ksh. Signed-off-by: Pavel Snajdr <[email protected]>
amotin
approved these changes
May 22, 2025
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Jun 13, 2025
It was reported that channel programs' zfs.get_prop doesn't work for dataset properties encryption and encryptionroot. They are handled in get_special_prop due to the need to call dsl_dataset_crypt_stats to load those dsl props. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Pavel Snajdr <[email protected]> Co-authored-by: Graham Christensen <[email protected]> Closes openzfs#17280
behlendorf
pushed a commit
that referenced
this pull request
Jun 17, 2025
It was reported that channel programs' zfs.get_prop doesn't work for dataset properties encryption and encryptionroot. They are handled in get_special_prop due to the need to call dsl_dataset_crypt_stats to load those dsl props. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Pavel Snajdr <[email protected]> Co-authored-by: Graham Christensen <[email protected]> Closes #17280
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Jun 17, 2025
It was reported that channel programs' zfs.get_prop doesn't work for dataset properties encryption and encryptionroot. They are handled in get_special_prop due to the need to call dsl_dataset_crypt_stats to load those dsl props. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Pavel Snajdr <[email protected]> Co-authored-by: Graham Christensen <[email protected]> Closes openzfs#17280
spauka
pushed a commit
to spauka/zfs
that referenced
this pull request
Aug 30, 2025
It was reported that channel programs' zfs.get_prop doesn't work for dataset properties encryption and encryptionroot. They are handled in get_special_prop due to the need to call dsl_dataset_crypt_stats to load those dsl props. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Pavel Snajdr <[email protected]> Co-authored-by: Graham Christensen <[email protected]> Closes openzfs#17280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#12337
Description
It was reported that channel programs' zfs.get_prop doesn't work for
dataset properties encryption and encryptionroot.
They are handled in get_special_prop due to the need to call
dsl_dataset_crypt_stats to load those dsl props.
@grahamc already worked on a testcase for this (#12335), we could revive and merge that PR now
How Has This Been Tested?
Reproducer in #12337
Types of changes
Checklist:
Signed-off-by.