update name

openxrlab · May 17, 2024 · 801c239 · 801c239
1 parent f8eeebf
commit 801c239
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -189,6 +189,6 @@ target_link_libraries(rec_1dsfm xrsfm)
 add_executable(rec_kitti src/rec_kitti.cc)
 target_link_libraries(rec_kitti xrsfm)
 
-add_executable(test_gui src/test_gui.cc)
-target_link_libraries(test_gui xrsfm)
-target_sources(test_gui PRIVATE ${RESOURCES})
+add_executable(xrsfm_gui src/xrsfm_gui.cc)
+target_link_libraries(xrsfm_gui xrsfm)
+target_sources(xrsfm_gui PRIVATE ${RESOURCES})
diff --git a/src/geometry/pnp.cc b/src/geometry/pnp.cc
@@ -79,12 +79,13 @@ bool RegisterImage(const int frame_id, Map &map) {
         num_inlier++;
         const auto &[p2d_id, track_id] = id_pair_vec[id];
         auto &track = map.track(track_id);
-        // TODO do something if this track has been observed by this frame
         if (track.observations_.count(frame_id) == 0) {
             frame.track_ids_[p2d_id] = track_id;
             track.observations_[frame_id] = p2d_id;
             map.AddNumCorHavePoint3D(frame_id, p2d_id);
             level_vec.emplace_back(track.hierarchical_level);
+        } else { // if this track has been observed
+            // TODO compare the reprojection error
         }
     }
     std::sort(level_vec.begin(), level_vec.end());

diff --git a/src/test_gui.cc → src/xrsfm_gui.cc b/src/test_gui.cc → src/xrsfm_gui.cc