[XLA:GPU] Fix Cublaslt fp8 to dummy nullptr c pointer when beta = 0 #34912
+31
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary of Changes
Fix Cublaslt fp8 to dummy nullptr c pointer when beta = 0
🎯 Justification
Since cuda 13.0, cublasLT adds a check that enforce gemm with same C and D pointer to have same descs. XLA uses same C and D pointer for in-place gemms which is fine. But for gemms with beta = 0, XLA also uses same C and D pointer even though C pointer is not needed by cublas. The new check will fail now in this case for fp8 gemms since C and D usually have different descs. The correct way is to use dummy C nullptr for gemms with beta = 0.
🚀 Kind of Contribution
🐛 Bug Fix
📊 Benchmark (for Performance Improvements)
None
🧪 Unit Tests:
these tests will pass with cuda 13 now:
🧪 Execution Tests:
None