Tidy up the parser checks for AsyncStart/Update/Done. #34907
+25
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we check that AsyncUpdate/Done have a single operand with a shape that conforms to the shape of AsyncStart, and the single operand is an Asynchronous op. This is now replaced by ensuring that AsyncUpdate/Done have a single operand which is an AsyncStart/Update. Previously, we check that AsyncUpdate has a result shape that conforms to the shape of AsyncStart. This is now replaced by ensuring that the AsyncUpdate operand and result have the same shape, like the HloVerifier does. PiperOrigin-RevId: 840775528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy up the parser checks for AsyncStart/Update/Done.
Previously, we check that AsyncUpdate/Done have a single operand with a shape that conforms to the shape of AsyncStart, and the single operand is an Asynchronous op. This is now replaced by ensuring that AsyncUpdate/Done have a single operand which is an AsyncStart/Update.
Previously, we check that AsyncUpdate has a result shape that conforms to the shape of AsyncStart. This is now replaced by ensuring that the AsyncUpdate operand and result have the same shape, like the HloVerifier does.