admin/rsyslog: add mmnormalize module support #26512
Conversation
|
Change commit tittle to |
carlo2007
force-pushed
the
add-liblognorm-package
branch
from
0b1c158 to
6d1e83e
Compare
carlo2007
changed the title
carlo2007
force-pushed
the
add-liblognorm-package
branch
from
6d1e83e to
b069a32
Compare
Thank you @wehagy, title changed. |
There was a problem hiding this comment.
Please read CONTRIBUTING.
Commits in your pull-requests should
- Have a useful commit subject prefixed with the package name (E.g.:
foopkg: Add libzot dependency).
| Liblognorm is a fast-samples based log normalization library | ||
| endef | ||
|
|
||
| TARGET_CFLAGS += $(FPIC) |
There was a problem hiding this comment.
What about enabled REGEXP support?
Dont we need to disable docs?
Have you checked https://github.com/rsyslog/liblognorm/blob/master/configure.ac#L189 ?
Anyway, I am not sure, if we want to add 8 years old library, which doesnt switch to PCRE2 support, yet.
rsyslog/liblognorm#374
There was a problem hiding this comment.
The docs building is not needed so I disabled it.
There was a problem hiding this comment.
Support for pcre2 would be optimal, but the rsyslog/liblognorm#374 is still open.
I prefer to stick to the original release by the author and not add a patch that integrates it.
Debian has also chosen to maintain the author's version in the last os release.
There was a problem hiding this comment.
Support for pcre2 would be optimal, but the rsyslog/liblognorm#374 is still open.
My biggest concern is that we dont have any package which relies on PCRE and we have all packages using PCRE2. (#22006) and I dont like to merge a new package, which is using PCRE.
Even though, it is disabled by default according to https://github.com/rsyslog/liblognorm/blob/01641bd80924731e6bad84025ed9a22dc480ef13/configure.ac#L73, but still someone tries to add PCRE2 support into liblognom 2 years ago and no one looked at it yet. This raises another potentionally redflag to add it here, because what if there is security flaw or some other nasty bug, which will needs to be fixed?
There was a problem hiding this comment.
@BKPepe thanks for your comment. I read #22006 and changelogs from https://www.pcre.org/. I totally agree with you and the community policy.
I left a comment in rsyslog/liblognorm#374 to try once again to get PCRE2 support in rsyslog/liblognorm. If no one will look in next days, I can write a patch to add the support to PCR2 in openwrt. What do you think about?
carlo2007
force-pushed
the
add-liblognorm-package
branch
from
b069a32 to
c99b57c
Compare
carlo2007
force-pushed
the
add-liblognorm-package
branch
2 times, most recently
from
4f93942 to
192f56d
Compare
carlo2007
force-pushed
the
add-liblognorm-package
branch
from
192f56d to
b6c2a45
Compare
carlo2007
force-pushed
the
add-liblognorm-package
branch
from
b6c2a45 to
a96f440
Compare
Liblognorm is a fast-samples based log normalization library. This library is required for rsyslog mmnormalize module. Signed-off-by: Carlo Filippi <[email protected]>
This module provides the capability to normalize log messages via liblognorm. If enabled, rsyslog package increases in size by about 4KB. Signed-off-by: Carlo Filippi <[email protected]>
carlo2007
force-pushed
the
add-liblognorm-package
branch
from
a96f440 to
fd07f58
Compare
3 participants
Maintainer: @neheb (last person to touch it)
Compile tested: mvebu, cortexa72, mikrotik_rb5009ug, openwrt-24.10; ramips, mt7621, ubnt_edgerouter-x, openwrt-24.10.
Run tested: mvebu, cortexa72, mikrotik_rb5009ug, openwrt-24.10; ramips, mt7621, ubnt_edgerouter-x, openwrt-24.10; in both devices, rsyslog was configured to normalize the received log messages and write them to a file and it was verified that the output complied with the configured normalization function.
Description: This adds mmnormalize module support to rsyslog. The module provides the capability to normalize log messages via liblognorm.
PR needs to be merged before: