treewide: themes: empty data-page on overview workaround#8553
Open
owlsy wants to merge 1 commit intoopenwrt:masterfrom
Open
treewide: themes: empty data-page on overview workaround#8553owlsy wants to merge 1 commit intoopenwrt:masterfrom
owlsy wants to merge 1 commit intoopenwrt:masterfrom
Conversation
At the moment, targeting CSS to the Status > Overview page isn't possible due to LuCI handling the data-page attribute with an empty data-page in HTML on log in, or if the hostname is clicked in the header (openwrt#8534). As a workaround, all existing CSS trying to target this page has been modified to best supply styling to this page, without it affecting the other pages. Signed-off-by: Joshua Criss <owlsy@outlook.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request details
Description
At the moment, targeting CSS to the Status > Overview page isn't possible due to LuCI handling the
data-pageattribute with an empty data-page in HTML on log in, or if the hostname is clicked in the header (#8534). The only way to have the CSS applied if is the user manually clicks on 'Overview' in the navbar, or by visiting/cgi-bin/luci/admin/status/overviewinstead of/cgi-bin/luci/.As a workaround, all existing CSS targeting this page has been modified to supply styling to this page, without it affecting the other pages. The only caveat here is the uniform spacing to the white boxes used for showing content applied for luci-theme-material, but is only a minor spacing change. This uniform spacing was going to only be applied to the Overview page, but will now be applied site-wide.
Maintainer (Preferred)
Pinging @systemcrash and @hnyman, due to previously approved PR merges I created based on themes.
Tested on
OpenWrt version: OpenWrt 25.12.2 (r32802-f505120278)
LuCI version: LuCI openwrt-25.12 branch (26.101.22673~0c81d2d)
Web browser: Safari Version 26.5 (21624.2.2)
Checklist
Signed-off-by: <my@email.address>row (viagit commit --signoff).<package name>: titlefirst line subject for packages.