Data integrity tests for the new connectome #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
|
Thanks for this! I am consolidating this with the other work by @ahrasheed in this branch. Still a few more tests to pass before I do a full pull request on it! |
|
@slarson Thank you, Stephen! Let me know if I can help with anything. |
signija
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #163 and is connected to #252 .
According to the info provided by @ahrasheed , the new tests cover the following:
Nothing changed for the test for the correct number of neurons (302). Just a note about the matching connections content: I essentially checked if all the connections in the csv file appear in the set returned by
Network.synapses()(i.e., if it's a subset). I didn't check the other way around (i.e., identical sets), but let me know if I should change that test at all.The tests have expected failure decorators at the moment, until the new connectome is merged. If any problems show up with the tests when that happens, or if anyone sees any problems at the moment, just let me know and I'll correct them.
cc @slarson @travs