Show Deprecated macros warning in PG editor and library Browser

[pstaabp]

This uses code from @somiaj to take the list of deprecated macros in the PG object and display only for instructors in the PGeditor and library browser.

Note: this needs openwebwork/pg#1256.

[pstaabp]

Updated to use the macroFileList within PG_loadMacros field of the PGcore object.

[drgrice1]

@pstaabp: I added a pull request to this branch that fixes some things. First, it only processes the $pg->{pgcore}{PG_locaMacros}{macroFileList} if $pg->{pgcore} is actually a PGcore object. Second, it improves the appearance of the warning generated in the javascript. You added p tags, but those aren't needed and mess up the margins giving inconsistent spacing, so those were removed as well as some other minor styling added.

[pstaabp]

Merged @drgrice1 's PR as noted above.

[somiaj]

Looks good.

One very minor thing, it seems that when chain loading macros, the chain loaded macros are listed before the originally loaded macro. For instance loadMacros('littleneck.pl') gives the following list of deprecated macros:

• problemRandomize.pl
• littleneck.pl

So even though the only macro loaded was littleneck.pl, a macro that was never loaded got listed first. I can't think of a way to fix this, just something I noticed.

[drgrice1]

@somiaj: The order that the macros are displayed does not depend on if one macro loads the other at all. It also doesn't depend on the order that the macros are loaded at all either. The macros are stored in the macroFileList hash of the PGloadfiles object. Since it is a hash it is not ordered. So the order the macros are displayed will be completely random. One time you will see problemRandomilze.pl first and littleneck.pl second. Another time you will see the opposite order. I just tried a problem that uses the littleneck.pl macro, and saw both orders in several renderings.

[somiaj]

Ahh, makes sense, it skipped my mind it was originally stored as a hash, which won't have order.

[drgrice1]

I think this looks good at this point.

Although, if we merge this, then there are now going to be warnings in the library browser, on the set details page, on the statistics page, on the problem grader page, and in the PG problem editor. So these message will be quite prevalent for instructors, and there are thousands of problems in the OPL that will give these warnings. Notably, many problems use the AnswerFormatHelp.pl macro. So we need to start working on those problems. Particularly replacing AnswerFormatHelp.pl usage with helpLink usage.

[dlglin]

Peter submitted openwebwork/webwork-open-problem-library#1279 to replace AnswerFormatHelp with helpLink, though I still don't like pushing out these warnings to all instructors. There are many problems in the OPL which use deprecated macros for which there aren't alternative problems available, and most instructors using these problems aren't in a position to update the problem code.

I think it's at least as likely that instructors see these warnings that the problems should not be used, and conclude that WeBWorK can't provide them with enough working problems.

[drgrice1]

I agree that we may not be ready for this yet. I think that work on OPL problems to fix deprecated macro usage should come first.

[pstaabp]

I can update this to go to develop if desired to wait a year.

[pstaabp]

Note: switched the destination branch to develop.