A few rendering tweaks. #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make links with `pg_files` start with a leading slash. * Honor the showCorrectAnswers setting and don't force it to be 2. * Make pg_files thirdPartyAssessts not force CDN use. * Remove the no longer needed `s/#/@/g` from version strings. * Some minor code cleanups.
drgrice1
reviewed
Jul 2, 2025
There was a problem hiding this comment.
This is not the correct baseURL approach. The key for the correct way to do this is to use the url_for method and route names (with appropriate stash values in some cases). I will put in a pull request at some point that fixes this. I have it implemented, but I am waiting for some of my other pull requests to be merged before I put it out there.
| showCorrectAnswers => $inputs_ref->{showCorrectAnswers} ? 2 : 0, | ||
| num_of_correct_ans => $inputs_ref->{numCorrect} || 0, | ||
| num_of_incorrect_ans => $inputs_ref->{numIncorrect} || 0, | ||
| showCorrectAnswers => $inputs_ref->{showCorrectAnswers} && $displayResults || 0, |
There was a problem hiding this comment.
This is still not right. The value of showCorrectAnswers should be numeric and should be one of 0, 1, or 2. This does not allow for a value of 2 which is the case that correct answers are shown without the button to reveal the correct answers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pg_filesstart with a leading slash.s/#/@/gfrom version strings.