Skip to content

Restructire the POD of macros (contexts) #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Alex-Jordan
Copy link
Contributor

This is part of an alternative to #1244, breaking it down into smaller PRs for review.

@Alex-Jordan Alex-Jordan force-pushed the restructure-pod-macros-contexts branch from 7f9bd73 to 19da4af Compare July 15, 2025 18:35
pstaabp and others added 2 commits July 15, 2025 14:37
Put `contextBoolean.pl` almost back to what it was other than the
addition of the `SYNPOSIS` header and reducing the levels after that,
but maintain the relative levels that @drdrew42 intended.

Other than that a few of the other usual things are fixed.
@drgrice1
Copy link
Member

I am going to add a pull request with a few suggestions here. Other than that this has the problem that the majority of the changes are not POD restructuring, but rather are clean up of comments.

@Alex-Jordan
Copy link
Contributor Author

I opened this PR, @pstaabp has approved it, and @drgrice1 wrote Alex-Jordan#32 that updated this. Does that mean it can be merged?

@drgrice1
Copy link
Member

The reason I haven't approved it is because it still is largely changes to comments.

@pstaabp
Copy link
Member

pstaabp commented Jul 21, 2025

I did some automatic reverting, but didn't work for all of the files. I fix the others.

@pstaabp
Copy link
Member

pstaabp commented Jul 21, 2025

@Alex-Jordan I reverted the rest of the comment changes I had made earlier. There's another PR on your branch.

@Alex-Jordan
Copy link
Contributor Author

I merged @pstaabp's reverting of the comment changes. Revieiwng the diff now in GitHub, I do still see some changes that are comment changes. But it's mostly POD changes now.

Copy link
Member

@drgrice1 drgrice1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, now this can be merged.

@drgrice1
Copy link
Member

There are a few minor changes to comments, but those are the good kind. That is better line wrapping and such.

@somiaj somiaj merged commit 1124d4f into openwebwork:PG-2.20 Jul 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants