Restructire the POD of macros (parsers) #1267
Conversation
| @@ -139,59 +138,54 @@ sub new { | |||
| return bless $f, $class; | |||
| } | |||
|
|
|||
| ################################################## | |||
There was a problem hiding this comment.
I often include separation lines like this to help group related methods together. I would prefer that they are left in, but, of course, the decision is up to you all. But I do find them helpful when I look at the code. Not everyone will.
| @@ -1,3 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
Remove the empty line added here. I think this is the result of the comments that were an inappropriate discussion in the code, and that were later removed at my request. The comments were removed, but the empty line added below the comments were not.
There was a problem hiding this comment.
I think that this pull request should perhaps be almost entirely reverted. That is everything except the actual POD changes. There is a lot of "clean up" of the comments in the code, and although I don't really like the comments like
#
# body of comment
#
i.e., the emtpy # lines before and after as those actually clutter the code and make the code less readable to me, these pull requests were intended to be POD clean up and restructuring, not comment clean up.
I can also see the usefulness of the full line ####### type comments that @dpvc commented on. Although, I still am not entirely favorable of those either.
In any case, that is not the point of the "POD restructuring".
|
I noticed that this was a bit of a mess when I went through it with the comment changes--I should have kept to the POD changes only. I'll remove all of the comment changes from this and add a PR. |
|
@Alex-Jordan Just added a PR to this. |
Revert changes to comments
This is part of an alternative to #1244, breaking it down into smaller PRs for review.