Creation of a PG critic script. #1254
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pg-critic
script analyzes a pgproblem (or list of them) for both good and bad features of a problem. Currently this include:Positive features:
Old and deprecated features
BEGIN_TEXT/END_TEXT
TEXT(beginproblem)
unionTables.pl
)num_cmp
,str_cmp
andfun_cmp
in lieu of using MathObjectsContext()->TeXStrings
loadMacros
more than once.$showPartialCorrectAnswers = 1
which is the default behavior and thus unnecessary.PGchoicemacros.pl
ENDDOCUMENT();
line indicating the end of the problem.Currently the script can also score a problem (there is a rubric that is built-in to the script). This can be made more flexible.
Also, there are plans to include more features on both the positive and negative side.