use_brand(): install and refresh the openwashdata brand - #110
Merged
Conversation
use_brand() copies _brand.yml and the logo files it references from the central openwashdata/brand repository (raw GitHub content at a configurable ref, or a local/alternative source for tests and offline work) into the active package. Re-running refreshes idempotently and reports written and updated files by md5 comparison; unchanged files stay untouched. With pkgdown = TRUE an existing _pkgdown.yml is wired to the brand through template.bslib.brand so the next site build renders with the brand fonts and colors; without a config the wiring is skipped with a setup_website() hint. Brand values are never edited locally, keeping the change-here-first discipline of the brand repo. Five tests cover install, idempotent refresh with source change, pkgdown wiring and re-run stability, the missing-config skip, and the missing-source error. Full suite passes at 63. Refs #109 Assisted-by: Claude claude-fable-5
…trial bslib resolves the brand through the brand.yml package at site build time; without it pkgdown::build_site() stops. Surfaced by the first end-to-end run on a real data package. Refs #109 Assisted-by: Claude claude-fable-5
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #109.
Summary
Test plan
Note: the default ref is main, which becomes functional once openwashdata/brand#1 merges; until then ref = "dev" exercises the real download path.