-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Helm charts created #35
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Rakesh Bajpayee <[email protected]>
Signed-off-by: Rakesh Bajpayee <[email protected]>
Signed-off-by: Rakesh Bajpayee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for this! Maybe you could add some simple docs on how to use this?
And maybe @jleach should also take a look? I'm not experienced in kubernetes setup
name: helm | ||
description: A Helm chart for Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we give these mediator specific names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will write the docs with the helm commands to install the application.
For the name: and description: I have left it default, but we can change that any time. Also suggest to me any note we should display after the helm deployment; I will write that too.
AGENT_NAME: Mediator | ||
WALLET_NAME: mediator | ||
WALLET_KEY: ${WALLET_KEY} | ||
POSTGRES_USER: ${POSTGRES_USER} | ||
POSTGRES_PASSWORD: ${POSTGRES_PASSWORD} | ||
POSTGRES_HOST: ${POSTGRES_HOST} | ||
POSTGRES_ADMIN_USER: ${POSTGRES_ADMIN_USER} | ||
POSTGRES_ADMIN_PASSWORD: ${POSTGRES_ADMIN_PASSWORD} | ||
AGENT_ENDPOINTS: "https://my-mediator.com,wss://my-mediator.com" | ||
LOG_LEVEL: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to be able to override all values. (Also wallet_name)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have written the values from the docker-compose.yaml file, it should be left with only "{}" this.
Like,
AGENT_NAME: {}
WALLET_NAME: {}
...
...
For reference I have done that. You can override the values as needed or can set the values with helm --set
flag during helm install. You can refer to this https://helm.sh/docs/helm/helm_install/
Signed-off-by: Rakesh Bajpayee <[email protected]>
Signed-off-by: Rakesh Bajpayee <[email protected]>
Co-authored-by: Timo Glastra <[email protected]> Signed-off-by: Rakesh Bajpayee <[email protected]>
@Helion55 We can start with this although we'll need to make some notable changes. I could list 'em off but I think this would turn into an epic. We can either keep this alive and keep chipping away at it or merge and I can start contributing to the helm charts also. Thoughts @TimoGlastra ? |
About this PR
This PR will add Helm Charts for the application. Deployment, Service, and Ingress manifests are created. The values.yaml file contains all the values for the manifests. NOTES.txt I have left empty because I feel maintainers can describe or change any stuff as required and this will be much more convenient to the end user.
In the Ingress, I have configured it to use with SSL certificates, and the required values can be filled during the deployment; otherwise, it can be ignored, and the service can be exposed in the classic way.
Note
Feature Added
Solved #32