Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align metadata with new Oid4Vci specs #53

Merged
merged 8 commits into from
May 3, 2024
Merged

Align metadata with new Oid4Vci specs #53

merged 8 commits into from
May 3, 2024

Conversation

JoTiTu
Copy link
Contributor

@JoTiTu JoTiTu commented Feb 15, 2024 •
edited
Loading

Short description of what this resolves:

This PR aligns the models with the updates Oid4Vci specs:

Changes proposed in this pull request:

  • IssuerMetadata
  • CredentialMetadata
  • CredentialOffer

@JoTiTu JoTiTu changed the title Align metadata with new spec Align metadata with new Oid4Vci specs Feb 15, 2024
@JoTiTu JoTiTu requested a review from Dindexx February 23, 2024 12:33
Dindexx
Dindexx approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@Dindexx Dindexx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ntsbs ntsbs merged commit 3882be6 into main May 3, 2024
3 checks passed
@ntsbs ntsbs deleted the align-metadata-with-new-spec branch May 3, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dindexx Dindexx Dindexx approved these changes

@ntsbs ntsbs ntsbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoTiTu @ntsbs @Dindexx