-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit scipy
to a secure version
#3857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've posted comments, but the final decision is up to @eaidova.
@@ -30,7 +30,7 @@ pyclipper>=1.2.1 | |||
# brain tumor segmentation | |||
nibabel>=3.2.1 | |||
# nncf's upperbound: https://github.com/openvinotoolkit/nncf/blob/a8af39627647ddbb89ef33cf42ff42e9c048b981/setup.py#L106 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've probably missed it in the last PR. Please remove the comment because you've removed the upper bound.
I checked nncf's develop branch and they still have that requirement. Setting scipy>=1.11.1
is going to cause conflicts.
@@ -30,7 +30,7 @@ pyclipper>=1.2.1 | |||
# brain tumor segmentation | |||
nibabel>=3.2.1 | |||
# nncf's upperbound: https://github.com/openvinotoolkit/nncf/blob/a8af39627647ddbb89ef33cf42ff42e9c048b981/setup.py#L106 | |||
scipy>=1.5.4 | |||
scipy>=1.11.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does that resolve the original problem? The build under openvinotoolkit/openvino#19458: https://openvino-ci.toolbox.iotg.sclab.intel.com/job/private-ci/job/ie/job/e2e-tests-linux-ubuntu20-pip-conflicts/40763/ fails with ERROR: Could not find a version that satisfies the requirement pip==23.1.2
Let's hold on for a bit with this PR, I'll run a kubernetes pod with the CI job and make 100% sure what's causing the issue.
That's an error which often appears and doesn't cause any harm, the pipeline continues - I guess it's just a matter of a bit messy Python environments on the CI. The real error is at the end of the logs, but now, after rebasing, I see that it's different: The conflict is caused by:
The user requested scipy
The user requested (constraint) scipy>=1.11.1 Let's disregard this PR for now, it seems the issue has "moved". I'm closing it, I'll reopen it if my findings point to OMZ again. |
Despite being lower bound only, this version still causes issues in OpenVINO pip-conflicts check at openvinotoolkit/openvino#19458
One way or another, bumping
scipy
lower bound to lowest secure version is a good change.Ticket: 117438