-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Added Tests for POT and NNCF Compression Types #2438
Open
sky0walker99
wants to merge
4
commits into
openvinotoolkit:main
Choose a base branch
from
sky0walker99:unit-test/engine-export-2273
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
🔨 Added Tests for POT and NNCF Compression Types #2438
sky0walker99
wants to merge
4
commits into
openvinotoolkit:main
from
sky0walker99:unit-test/engine-export-2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky0walker99
requested review from
samet-akcay,
ashwinvaidya17 and
djdameln
as code owners
November 26, 2024 14:14
@ashwinvaidya17, will you be able to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I've added a few comments
…updated test_export Signed-off-by: Haroon <[email protected]>
Signed-off-by: Haroon <[email protected]>
Signed-off-by: Haroon <[email protected]>
Signed-off-by: Haroon <[email protected]>
sky0walker99
force-pushed
the
unit-test/engine-export-2273
branch
from
December 2, 2024 18:19
b94c6c5
to
c4a11d5
Compare
ashwinvaidya17
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
-This PR addresses the missing tests for the POT (Post-Training Optimization Tool) and NNCF (Neural Network Compression Framework) features in Engine.export. This PR adds unit tests to verify the export functionality with these compression types.
Ensures
compression_type
is used only with OPENVINO export type, raising an error if violated in Engine.exportAdded tests in
test_cli
to cover all compression type combinations.attributes POT (Post-Training Optimization) and NNCF (Neural Network Compression Framework) to the
CompressionType
🛠️ Fixes [Task]: Add unit tests for
Engine.export
#2273✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.