Move microrl token parsing arrays from the stack to the heap#1373
Merged
dexterbg merged 4 commits intoopenvehicles:masterfrom Apr 12, 2026
Merged
Move microrl token parsing arrays from the stack to the heap#1373dexterbg merged 4 commits intoopenvehicles:masterfrom
dexterbg merged 4 commits intoopenvehicles:masterfrom
Conversation
so we can increase _COMMAND_TOKEN_NMB (and allow more can capture filter terms without impacting stack usage). Other fixed sized arrays in the module prevent more than about 128 from being helpful. The changes to microrl_get_complite() are untested (and not used by ovms).
Member
|
Craig,
Regards, |
Prefer SPIRAM over INTERNAL. Fix memory leak in microrl_get_complite(). rl_get_complite() does not return a value.
Contributor
Author
|
If you prefer I can switch from compile time to run time SPIRAM detection; I believe the call looks something like this: |
Member
|
From So the correct call to prioritize SPIRAM is: Regards, |
Contributor
Author
|
I tried to bring my branch up to date but I suck too badly at git... Here's the version that uses heap_caps_malloc_prefer() |
Member
|
Looks good now, except for the inclusion of the canlog vfs component in the PR. I'd rather have this PR focusing on the microrl changes, and a second PR for the canlog changes -- and the canlog PR then should include all log formats. If this exceeds your git skills, it's also OK to include the canlog changes here, but they should then be complete (all formats). |
As requested by @dexterbg. Also, the change is missing for other cases (e.g. "can log start monitor crtd")
leres
added a commit
to leres/Open-Vehicle-Monitoring-System-3
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so we can increase _COMMAND_TOKEN_NMB (and allow more can capture filter terms without impacting stack usage).
Other fixed sized arrays in the module prevent more than about 128 from being helpful.
The changes to microrl_get_complite() are untested (and not used by ovms).