Skip to content

Remove requirements directory #2812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 14, 2025
Merged

Remove requirements directory #2812

merged 15 commits into from
Apr 14, 2025

Conversation

thewhaleking
Copy link
Contributor

Remove requirements directory, change workflows to not use this

@thewhaleking thewhaleking requested a review from a team April 10, 2025 18:50
basfroman
basfroman previously approved these changes Apr 10, 2025
View reviewed changes
@basfroman
Copy link
Contributor

Some scripts from the /scripts folder use the ./requirements/* files and are involved in the CI workflows.
Let's take a closer look at this and make sure that CI doesn't break.

@thewhaleking
Copy link
Contributor Author

Some scripts from the /scripts folder use the ./requirements/* files and are involved in the CI workflows. Let's take a closer look at this and make sure that CI doesn't break.

Resolved.

basfroman
basfroman approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@basfroman basfroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Let's keep it for the next release and merge it right before creating the release branch.

@thewhaleking thewhaleking merged commit 86d4367 into staging Apr 14, 2025
125 checks passed
@thewhaleking thewhaleking deleted the feat/thewhaleking/remove-requirements-dir branch April 14, 2025 17:27
@ibraheem-abe ibraheem-abe mentioned this pull request Apr 14, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camfairchild camfairchild camfairchild approved these changes

@basfroman basfroman basfroman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thewhaleking @basfroman @camfairchild