Era param for set_weights and commit_weights #2784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyzniewski-reef
force-pushed
the
feat/zyzniewski/era_param
branch
2 times, most recently
from
5d506c3 to
55177b9
Compare
zyzniewski-reef
commented
Apr 2, 2025
| @@ -3831,6 +3846,7 @@ async def _blocks_weight_limit() -> bool: | |||
| version_key=version_key, | |||
| wait_for_inclusion=wait_for_inclusion, | |||
| wait_for_finalization=wait_for_finalization, | |||
| era=era if era is not DEFAULT_SET_WEIGHTS_EXTRINSIC_ERA else None, | |||
There was a problem hiding this comment.
for backward compatibility: commit_reveal_v3_extrinsic has default era = None
zyzniewski-reef
commented
Apr 2, 2025
| @@ -3111,6 +3127,7 @@ def _blocks_weight_limit() -> bool: | |||
| version_key=version_key, | |||
| wait_for_inclusion=wait_for_inclusion, | |||
| wait_for_finalization=wait_for_finalization, | |||
| era=era if era is not DEFAULT_SET_WEIGHTS_EXTRINSIC_ERA else None, | |||
There was a problem hiding this comment.
for backward compatibility: commit_reveal_v3_extrinsic has default era = None
zyzniewski-reef
force-pushed
the
feat/zyzniewski/era_param
branch
from
55177b9 to
de2b4c9
Compare
thewhaleking
reviewed
Apr 2, 2025
thewhaleking
previously approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing the period should also help with E2E tests in fast-blocks