Update Pennsylvania State Legislators images #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexobaseki
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Pennsylvania images were no longer working (I assume due to the new website they are moving to palegis versus legis.state.pa.us) this is my attempt to fix PA state legislator images.
Example:
Aaron Bernstine:
Old: https://www.legis.state.pa.us/images/members/200/1742.jpg?1703415645672
New: https://www.palegis.us/resources/images/members/200/1742.jpg?20241220
I'm not sure why the python yaml dumper moved all of the birth_date fields to be closer to the image field, but the values are unchanged so shouldn't affect anything since yaml fields have no ordering per the spec.