Skip to content

Conversation

Deydra71
Copy link

@Deydra71 Deydra71 commented Aug 13, 2025

Jira: OSPRH-16627

This PR adds end-to-end support for consuming Keystone ApplicationCredentials (AC) in the Swift operator, enabling Swift Proxy pods to use AC-based authentication when available.

Reconcile:

On each reconcile, the Swift Proxy controller checks for an AC Secret (ac-{service}-secret) using the GetApplicationCredentialFromSecret() helper from keystone-operator API:

If the secret is missing or incomplete, continues using password authentication
Once the AC Secret is ready with valid AC_ID and AC_SECRET fields, templates AC credentials into Swift PRoxy configuration
Computes hash of Secret contents and stores in configVars to trigger rolling updates when credentials rotate
RBAC permissions:

Added read permissions for secrets resources to allow fetching AC secrets.

Depends-On: openstack-k8s-operators/keystone-operator#567

Copy link
Collaborator

@cschwede cschwede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my inline comment

secretRef,
os.GetRegion(),
transportURLString,
<<<<<<< HEAD
Copy link
Collaborator

@cschwede cschwede Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an unresolved merge conflict

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this up! Also I will soon push update to this PR anyway to reflect latest changes in keystone-operator

Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Deydra71
Once this PR has been reviewed and has the lgtm label, please ask for approval from cschwede. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

@Deydra71: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional 139670c link true /test functional
ci/prow/precommit-check 139670c link true /test precommit-check
ci/prow/swift-operator-build-deploy-kuttl 139670c link true /test swift-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants