-
Notifications
You must be signed in to change notification settings - Fork 26
AppCred service operator support #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
22e9b75
to
7b386fd
Compare
7b386fd
to
8a888f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my inline comment
controllers/swiftproxy_controller.go
Outdated
secretRef, | ||
os.GetRegion(), | ||
transportURLString, | ||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an unresolved merge conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this up! Also I will soon push update to this PR anyway to reflect latest changes in keystone-operator
8a888f7
to
901b259
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Deydra71 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
901b259
to
919c881
Compare
919c881
to
c74f3b4
Compare
c74f3b4
to
139670c
Compare
@Deydra71: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Jira: OSPRH-16627
This PR adds end-to-end support for consuming Keystone ApplicationCredentials (AC) in the Swift operator, enabling Swift Proxy pods to use AC-based authentication when available.
Reconcile:
On each reconcile, the Swift Proxy controller checks for an AC Secret (ac-{service}-secret) using the GetApplicationCredentialFromSecret() helper from keystone-operator API:
If the secret is missing or incomplete, continues using password authentication
Once the AC Secret is ready with valid AC_ID and AC_SECRET fields, templates AC credentials into Swift PRoxy configuration
Computes hash of Secret contents and stores in configVars to trigger rolling updates when credentials rotate
RBAC permissions:
Added read permissions for secrets resources to allow fetching AC secrets.
Depends-On: openstack-k8s-operators/keystone-operator#567