Add AtLatestKnown condition #1517
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hjensas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hjensas
force-pushed
the
minor-version-condition
branch
3 times, most recently
from
3c78b02 to
f984331
Compare
hjensas
force-pushed
the
minor-version-condition
branch
3 times, most recently
from
844a0a2 to
b9e5bbb
Compare
| corev1beta1.OpenStackVersionMinorUpdateAvailable, | ||
| corev1beta1.OpenStackVersionMinorUpdateAvailableMessage)) | ||
| } else { | ||
| instance.Status.Conditions.Set(condition.FalseCondition( |
There was a problem hiding this comment.
with this change, the openstackversion won't reach the ready state if there is no update available because it would be always false if there is no update. The ready state can only reached when all sub conditions are true. Or am I miss-read it?
There was a problem hiding this comment.
oh no, you are right @stuggi - I pushed another version with a test to check the Ready condition - it should fail functional test with that ... and I'll move this to work in progress.
conditions:
- lastTransitionTime: "2025-06-29T14:07:57Z"
message: at latest known
reason: AtLatestKnown
severity: Info
status: "False"
type: Ready
- lastTransitionTime: "2025-06-29T14:02:40Z"
message: completed
reason: Ready
status: "True"
type: Initialized
- lastTransitionTime: "2025-06-29T14:07:57Z"
message: at latest known
reason: AtLatestKnown
severity: Info
status: "False"
type: MinorUpdateAvailable
There was a problem hiding this comment.
I think it would be helpful to have something "boolean"'ish to check, that won't return an error if I used oc wait.
Proposing a new version with an AtLatestKnown condition.
An alternative would be a status field, similar to the state field in Subscription which is set to UpgradePending or AtLatestKnown.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/22bd08115bd6431cb99394cc02e1d25d ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 45m 44s |
hjensas
force-pushed
the
minor-version-condition
branch
from
b9e5bbb to
0b14ebd
Compare
Add a condition to indicate if we are AtLatestKnown version. Condition is set to `True` if `AvailableVersion` == `DeployedVersion`, otherwize not set. With this change we can do: `wait --for condition=MinorUpdateAvailable`, then patch the targetVersion and wait for: `wait --for condition=AtLatestKnown`. It is a nuance, but I think this can be useful for automation using oc wait.
hjensas
force-pushed
the
minor-version-condition
branch
from
0b14ebd to
d17be01
Compare
hjensas
changed the title
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/51330f04251b488e96a2def653ca6623 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 15s |
|
/test openstack-operator-build-deploy-kuttl-4-18 |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/71450504151442819a3f0f867d993f81 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 50s |
Add a condition to indicate if we are AtLatestKnown version.
Condition is set to
TrueifAvailableVersion==DeployedVersion, otherwize not set.With this change we can do:
wait --for condition=MinorUpdateAvailable, then patch the targetVersion and wait for:wait --for condition=AtLatestKnown.It is a nuance, but I think this can be useful for automation using oc wait.