Skip to content

Conversation

@mauricioharley
Copy link

This PR adds the ability to specify custom environment files for TripleO and Standalone OpenStack deployments through a new ADDITIONAL_ENV_FILE parameter.

Motivation
Users may need to pass custom environment configurations to their OpenStack deployments without modifying the existing deployment scripts. This enhancement provides a clean, standardized way to inject additional environment files into the deployment process.

Changes

  • Makefile: Maps ADDITIONAL_ENV_FILE to deployment-specific variables (TRIPLEO_ADDITIONAL_ENV and STANDALONE_ADDITIONAL_ENV)
  • Deployment scripts:
    • Export the environment variables
    • Conditionally copy additional environment files to target systems via SCP
    • Include them in deployment commands using the -e flag when present

Usage

# For TripleO deployment
make tripleo_deploy ADDITIONAL_ENV_FILE=/path/to/custom-env.yaml

# For Standalone deploymentmake 
standalone_deploy ADDITIONAL_ENV_FILE=/path/to/custom-env.yaml

@openshift-ci openshift-ci bot requested review from abays and stuggi November 19, 2025 16:56
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mauricioharley
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Introduces additional parameter support for both TripleO and
Standalone deployments to enable users to provide custom environment
configurations without modifying deployment scripts.

Changes:
- Export TRIPLEO_ADDITIONAL_ENV and STANDALONE_ADDITIONAL_ENV variables
  in respective deployment scripts
- Copy additional environment files to target systems when specified
- Conditionally include additional environment files in openstack-tripleo
  deployment commands using -e flag

Signed-off-by: Mauricio Harley <[email protected]>
@mauricioharley mauricioharley force-pushed the add_extended_parameters branch from d80ee7f to d004e0b Compare November 20, 2025 10:28
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a6c66daed71348c1868a6ce9c90151ee

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 33m 35s
install-yamls-crc-podified-edpm-baremetal FAILURE in 31m 16s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 36m 56s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 08m 50s
✔️ adoption-standalone-to-crc-no-ceph-provider SUCCESS in 3h 15m 27s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant