Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exempt feature branches from the 24 hour delay for merging #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Exempt feature branches from the 24 hour delay for merging #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions policies/committer-policy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ delay from the approval. An exception to the delay exists for build and
test breakage fix approvals which should be flagged with the _severity:
urgent_ label.

Given that feature branches are merged to the mainline branch via a separate PR,
PR submissions to the feature branch which are otherwise approved are exempted
from the 24-hour delay above.

The use of the _severity: urgent_ label should be limited to contexts where the
breakage of the CI builds and tests (including buildbot) happened within the
last 72 hours and the change is straightforward.
Expand Down