feat: use GeneratedCallables for handling console methods #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add proper *args handling in IntrospectingConsole.create_signatures_and_params() - Convert *args to _unknown_args_from_varargs dict to bridge incompatible interfaces - Update publish_known_event() to process converted *args data - Fix LogTestResults field ordering to prevent syntax errors - Update SQLMesh constraint from <0.188 to >=0.188 Fixes compatibility issue with SQLMesh 0.209.0 which added *args/**kwargs to log_error() and log_warning() abstract methods. Without this fix, the dynamic method generation creates invalid Python syntax that prevents import. The solution preserves all argument data in unknown_args while maintaining the clean **kwargs-only interface of the event system. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Replace dynamic exec() generation with proper callable class pattern for better maintainability, type safety, and debugging capability. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
@ravenac95 fyi, there's some method signature changes in the recent versions of SQLMesh, so you might need to cap this to 0.209.0, and then make further changes to increase the compatibility to the latest versions. |
|
@lucargir depending on the signature changes, the current design might handle it but I've got a test breaking i've not been able to fix on this branch. I need to check if it's the upgrade to 0.209.0 on this branch. I should also push up some additional work I have in progress for this. |
brunoalano
added a commit
to brunoalano/dagster-sqlmesh
that referenced
this pull request
Sep 28, 2025
… console and backfilling integration\n- Support latest Dagster and SQLMesh versions\n- Exclude private README changes; keep upstream README\n\nRefs: opensource-observer#49, closes opensource-observer#43; follow-up to opensource-observer#52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is originally from #49
Closes #43