Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added error annotation on github actions #31

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

aj3sh
Copy link
Member

@aj3sh aj3sh commented Apr 2, 2024

Description

Added GitHub actions error message if commitlint fails.

Extra:

  • Removed failed_on_error from the test_actions workflow.
  • Updated docs for github actions

Related Issue

Fixes #24

Type of Change

Please mark the appropriate option below to describe the type of change your pull request introduces:

  • Bug fix
  • New feature
  • Enhancement
  • Documentation update
  • Refactor
  • Other (please specify)

Checklist

  • My pull request has a clear title and description.
  • I have used semantic commit messages.
    Examples: "fix: Fixed foobar bug", "feat(accounts): Added foobar feature".
  • I have added/updated the necessary documentation on README.md.
  • I have added appropriate test cases (if applicable) to ensure the changes are functioning correctly.

Additional Notes

Outcome:
Screenshot 2024-04-03 at 7 41 46 PM

By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.

@aj3sh aj3sh requested review from subashcs and sugat009 April 2, 2024 16:41
@subashcs
Copy link
Collaborator

subashcs commented Apr 5, 2024

Looks good

@subashcs subashcs merged commit 8761e42 into opensource-nepal:main Apr 5, 2024
3 checks passed
@aj3sh aj3sh deleted the actions-error-msg branch April 5, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commitlint actions do not display error messages in the Annotation section
3 participants